Related
I tried flashing magisk v15 on miui global beta mm, but when I boot to system I couldn't find magisk installed . I also tried installing apk but it said magisk not installed. Magisk v14 works on this ROM( Magisk v15 works on my nos 8.1)
tom jp said:
I tried flashing magisk v15 on miui global beta mm, but when I boot to system I couldn't find magisk installed . I also tried installing apk but it said magisk not installed. Magisk v14 works on this ROM( Magisk v15 works on my nos 8.1)
Click to expand...
Click to collapse
Mine is working fine, magisk 15. Miui 9 latest dev beta.
rajbain said:
Mine is working fine, magisk 15. Miui 9 latest dev beta.
Click to expand...
Click to collapse
Which build, I tried it on 8th Dec build
I've also tried magisk v15 on my miui8 kenjo. its showing that magisk not installed. but v14 is working.
I have the same. Redmi 4A and Redmi 4Pro. Rom Xiaomi.eu 7.12.28. Magisk 14.0 works correctly. However, 15.0 and 15.1 can not be installed. Installation via twrp also does not change anything.
Same problem with redmi 4 pro miui 9.2 stable (xiaomi.eu)
java.lang.RuntimeException: An error occurred while executing doInBackground()
at android.os.AsyncTask$3.done(AsyncTask.java)
at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
at java.util.concurrent.FutureTask.run(FutureTask.java:242)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
at java.lang.Thread.run(Thread.java:818)
Caused by: java.lang.OutOfMemoryError: Failed to allocate a 134209548 byte allocation with 16777216 free bytes and 113MB until OOM
at java.io.ByteArrayOutputStream.expand(ByteArrayOutputStream.java:91)
at java.io.ByteArrayOutputStream.write(ByteArrayOutputStream.java:201)
at com.topjohnwu.crypto.ByteArrayStream.readFrom(Unknown Source)
at com.topjohnwu.crypto.ByteArrayStream.readFrom(Unknown Source)
at com.topjohnwu.crypto.SignBoot.verifySignature(Unknown Source)
at com.topjohnwu.magisk.asyncs.InstallMagisk.doInBackground(Unknown Source)
at com.topjohnwu.magisk.asyncs.InstallMagisk.doInBackground(Unknown Source)
at android.os.AsyncTask$2.call(AsyncTask.java)
at java.util.concurrent.FutureTask.run(FutureTask.java:237)
... 3 more
i'm also facing the same problem. in my case even v14 isn't working.
send me your zip link
ktanay said:
i'm also facing the same problem. in my case even v14 isn't working.
send me your zip link
Click to expand...
Click to collapse
Hi, I used the official version, you can download it from the official XDA thread
I also have it up and running... I updated from v14 to v15, then v15.1 and i reboot to flash v15.2 now.
Rom: Official Global Developer
Version: 7.12.28 (latest when i write this post)
GreatApo said:
I also have it up and running... I updated from v14 to v15, then v15.1 and i reboot to flash v15.2 now.
Rom: Official Global Developer
Version: 7.12.28 (latest when i write this post)
View attachment 4377599 View attachment 4377600
Click to expand...
Click to collapse
What version of TWRP are you running?, did you update from 14, 15, and 15.1 at once or reboot after each update, I also noticed you have force preserve force encryption checked,
otyg said:
What version of TWRP are you running?, did you update from 14, 15, and 15.1 at once or reboot after each update, I also noticed you have force preserve force encryption checked,
Click to expand...
Click to collapse
I am running the ZCX TWRP (i think it's v3.0.2, available here in xda). I had installed v14.x and I was constantly updating when the new versions became available. I am now on 15.2 (so not all at once). I don't remember pressing the force encryption button, maybe it was checked for me...
GreatApo said:
I am running the ZCX TWRP (i think it's v3.0.2, available here in xda). I had installed v14.x and I was constantly updating when the new versions became available. I am now on 15.2 (so not all at once). I don't remember pressing the force encryption button, maybe it was checked for me...
Click to expand...
Click to collapse
Strange since I could not update to 15.2 no matter what I tried (only 14.0 would work), I was also using ZCX TWRP, I recently updated to redwolf twrp and now Magisk 15.2 went in fine, but I think it does have something to do with "force encryption" since RedWolf TWRP has a option "disable force encryption" and "disable dm-verity" , I don't think the first option was in ZCX twrp, so maybe when that got checked in your magisk manager it fixed it the same way the newer twrp does.
for people having issues here are the steps that worked for me
https://forum.xda-developers.com/redmi-note-3/how-to/guide-how-to-install-magisk-15-2-kenzo-t3729329
otyg said:
Strange since I could not update to 15.2 no matter what I tried (only 14.0 would work), I was also using ZCX TWRP, I recently updated to redwolf twrp and now Magisk 15.2 went in fine, but I think it does have something to do with "force encryption" since RedWolf TWRP has a option "disable force encryption" and "disable dm-verity" , I don't think the first option was in ZCX twrp, so maybe when that got checked in your magisk manager it fixed it the same way the newer twrp does.
for people having issues here are the steps that worked for me
https://forum.xda-developers.com/redmi-note-3/how-to/guide-how-to-install-magisk-15-2-kenzo-t3729329
Click to expand...
Click to collapse
Awesome! Here is your "thanks" for helping others
otyg said:
for people having issues here are the steps that worked for me
https://forum.xda-developers.com/redmi-note-3/how-to/guide-how-to-install-magisk-15-2-kenzo-t3729329
Click to expand...
Click to collapse
I'm having trouble with the part about flashing the Magisk Uninstaller file, since my device (Redmi Note 2) is encrypted, I can't seem to make it work from the TWRP, in the same way wiping the Dalvik/Cache doesn't work.
So I'm stuck on Magisk 14 and even the direct update from the Magisk app puts my device in a bootloop (resolved only by installing the latest rom from the TWRP), maybe because I can't uninstall Magisk properly.
Should I try to flash the uninstall package from the adb?
EDIT: I finally managed to solve it by
1: Uninstalling Magisk from the Magisk manager app itself rather than flashing the uninstaller zip
2: Rebooted into the TWRP recovery where I first followed the instructions here under "Keeping dm-verity and forced encryption
": https://forum.xda-developers.com/showpost.php?p=73145975&postcount=2
3: and I then installed the latest Magisk 15.3
booted into system and no bootloop this time, successfully switched from Magisk 14 to 15
Hello.
I have a big problem, I tried root on op5 android 8.0 ... I unlocked bootloader OK, flash TWRP - twrp-3.2.1-x_blu_spark_v8.61-op5_op5t OK ....i install SUPER SU OK, .... wipe cache .....restart mobile and . Mobile its frozen on ONEPLUS LOGO...then i download stock ROM and stock TWRP... Flash stock TWRP, instal with ADB sidelock stock ROM, wipe cache and reboot....OP5 looks good.. But i have android 7.1.1 and oxygen os 4.5.2 .... OP5 works... but i want android 8 oreo... i go to settings aktualization....and show update oxygen OS 5.0.2 .. I tried autoupdate ... Download 1.6gb and install... Install failed...Then i tried download manually on oneplus site...and take on internal storage and install manualy... And installation failed... What am I doing wrong ? Im sorry for my bad english... Thanks for help
great news...all problems was unlocked bootloader... i flash stock twrp and install stock ROM...telefon run with no problem and with android 7.1.1...then i locked bootloader, and copy oxygen OS 5.0.0 open beta 1 ...download from oneplus site..and paste on internal storage...and install package in settings/update / local update....All problems was unlocked bootloader.
Hi fellows
I wanted to root my Mi 9T, but I don't want to flash a custom rom, I just want to have root on the official rom (global stable).
As I understand, the correct procedure is:
-unlock nootloader
-flash twrp
-flash magisk
But I have a couple of doubts about this, in particular about updates:
-If my phone is unlocked and I have root, will I still receive official updates from xiaomi?
-if yes, do they install via twrp? Do they fail installation? Do I loose root/bootloader unlock if I install them on unlocked/rooted phone?
-if no, is there an alternative way to install updates without losing root every time?
In other words, what is the best way to have a rooted phone but with official, up-to-date rom? (I have no problems downloading/installing updates manually, but having to reapply root every time would be annoying)
Master_T said:
Hi fellows
I wanted to root my Mi 9T, but I don't want to flash a custom rom, I just want to have root on the official rom (global stable).
As I understand, the correct procedure is:
-unlock nootloader
-flash twrp
-flash magisk
But I have a couple of doubts about this, in particular about updates:
-If my phone is unlocked and I have root, will I still receive official updates from xiaomi?
-if yes, do they install via twrp? Do they fail installation? Do I loose root/bootloader unlock if I install them on unlocked/rooted phone?
-if no, is there an alternative way to install updates without losing root every time?
In other words, what is the best way to have a rooted phone but with official, up-to-date rom? (I have no problems downloading/installing updates manually, but having to reapply root every time would be annoying)
Click to expand...
Click to collapse
As I know you could receive updates if you unlock your bootloader and flash magisk, I don't have experience with that, I've read that from other brands people do this and still get their updates.
If I'm wrong correct my.
• You will receive the ota but it won't install
• You'll have to install the full rom and reflash Magisk everytime
• Orange Fox recovery can install ota BUT not available for Mi 9T/K20
I'm not sure about Mi 9t (have to wait for bootloader unlock), but it was so on Redmi 3s: I can install OTA updates, it goes through TWRP, but after every update I have to flash Magisk.
It was several years ago, so probably they've changed something
Thanks for your replies guys.
I can now confirm (just tested) that to update a rooted mi9t all you have to do is this:
-flash update zip with twrp (you have to download the update zip from somewhere, like mifirm website, the one downloaded by the update tool is encrypted and won't work!)
-flash magisk
-reboot
Very simple! No need to reflash magisk modules, just the magisk base package and everything works as expected ?
Master_T said:
Thanks for your replies guys.
I can now confirm (just tested) that to update a rooted mi9t all you have to do is this:
-flash update zip with twrp (you have to download the update zip from somewhere, like mifirm website, the one downloaded by the update tool is encrypted and won't work!)
-flash magisk
-reboot
Very simple! No need to reflash magisk modules, just the magisk base package and everything works as expected
Click to expand...
Click to collapse
Which twrp and magisk do you use?
grinandbearit said:
Which twrp and magisk do you use?
Click to expand...
Click to collapse
First TWRP that came out (LR Team), but that is because it was the only one available at the time, there might be better ones out now, check the TWRP thread for more info.
Magisk, I used the latest stable release.
Master_T said:
Thanks for your replies guys.
I can now confirm (just tested) that to update a rooted mi9t all you have to do is this:
-flash update zip with twrp (you have to download the update zip from somewhere, like mifirm website, the one downloaded by the update tool is encrypted and won't work!)
-flash magisk
-reboot
Very simple! No need to reflash magisk modules, just the magisk base package and everything works as expected
Click to expand...
Click to collapse
I think it is more simple to do the update and reflash magisk instead of searching for the update package manually, isn't it?
Edit: wrong quote
fabsen said:
I think it is more simple to do the update and reflash magisk instead of searching for the update package manually, isn't it?
Click to expand...
Click to collapse
You mean flash the fastboot rom using a computer and then reinstall twrp and magisk?
Seems more convoluted to me, since you still need to download the rom from an external website and additionally you need a pc and you need to reflash twrp every time.... it'll probably work fine, but it seems more complicated to me
Master_T said:
You mean flash the fastboot rom using a computer and then reinstall twrp and magisk?
Seems more convoluted to me, since you still need to download the rom from an external website and additionally you need a pc and you need to reflash twrp every time.... it'll probably work fine, but it seems more complicated to me
Click to expand...
Click to collapse
Nah, I mean you flash the update you get the usual way. And then magisk afterwards. At least I've never lost twrp with OTA updates.
fabsen said:
Nah, I mean you flash the update you get the usual way. And then magisk afterwards. At least I've never lost twrp with OTA updates.
Click to expand...
Click to collapse
You mean the one downloaded through the miui updater? I can't flash that with twrp, it's encrypted. In fact, I can't even open the zip file with file manager, it says the file is corrupted. How do you decrypt/use it?
Few days ago I got OTA update while having magisk root and TWRP installed. It rebooted phone into TWRP and installed itself through TWRP. So it seems Xiaomi can now detect what recovery you are using and instead send you recovery OTA instead? Sadly I lost TWRP and root this way and needed to find newer TWRP (old one didnt boot and caused bootloop). Rom also didnt boot (after flashing new TWRP) until I flashed magisk.
Thank you all, it's nice to find this post before I create a new with the same questions.
I bought a new "Mi 9t", it received the latest OTA update, and it has been unlocked after waiting 170 hours.
MIUI Version: MIUI Global 10.3.11 Stable
Android Version: 9 PKQ1.190302.001
Model Name: M1903F10G
Now I need to root it without flashing twrp, I need to be on the Stock recovery because I don't want to lose the OTA update.
I ran this command :
Code:
C:\adb>fastboot boot recovery.img
Downloading ‘boot.img’ OKAY [ 1.404s]
booting OKAY [ 0.127s]
Finished. Total time: 1.560s
but the device reboot to MI-Recovery 3.0, can someone correct me if I'm wrong? also which twrp version support MIUI Global 10.3.11 Stable?
Matthas said:
Few days ago I got OTA update while having magisk root and TWRP installed. It rebooted phone into TWRP and installed itself through TWRP. So it seems Xiaomi can now detect what recovery you are using and instead send you recovery OTA instead? Sadly I lost TWRP and root this way and needed to find newer TWRP (old one didnt boot and caused bootloop). Rom also didnt boot (after flashing new TWRP) until I flashed magisk.
Click to expand...
Click to collapse
Weird, I tried that (downloading update from the updater app and rebooting to twrp to auto-flash it), but TWRP said update was corrupted. I had to download an unencrypted version from mifirm site to flash it with twrp.
Maybe it's a problem with the version of twrp? Which one are you using? I'm using the one from LR Team
Master_T said:
Weird, I tried that (downloading update from the updater app and rebooting to twrp to auto-flash it), but TWRP said update was corrupted. I had to download an unencrypted version from mifirm site to flash it with twrp.
Maybe it's a problem with the version of twrp? Which one are you using? I'm using the one from LR Team
Click to expand...
Click to collapse
oh I wish I knew After update when I went to flash back old twrp and magisk it resulted in bootloop so I was flashing all twrp I could find just to make them boot and then be able to flash magisk. However name of my file is "recovery-TWRP-3.3.1-0607-REDMI_K20-CN-wzsx150" I think its "fixed" chinese one.
Is "recovery-TWRP-3.3.1-0607-REDMI_K20-CN-wzsx150" support for MIUI Global 10.3.11 Stable?
Can I boot from it to root Mi 9T without flashing?
akha666 said:
Is "recovery-TWRP-3.3.1-0607-REDMI_K20-CN-wzsx150" support for MIUI Global 10.3.11 Stable?
Can I boot from it to root Mi 9T without flashing?
Click to expand...
Click to collapse
Is any expert have an answer to my questions?
Schnedi said:
• You will receive the ota but it won't install
• You'll have to install the full rom and reflash Magisk everytime
• Orange Fox recovery can install ota BUT not available for Mi 9T/K20
Click to expand...
Click to collapse
How do i root global stable rom 10.3.11 without bootlooping? Just rooting and no twarp .
[Q&A] [Collection] Latest TWRP for Asus ZenFone Max Pro M1 & Can TWRP Decrypt?
Hi there. If you still wonder that Can TWRP Decrypt Encrypted Data? The answer is YES. I will explain you why it's always FAIL.
Can TWRP Decrypt Data?First, you must understand HOW does TWRP Decrypt works.
Every month, Google will release new Security Patch for Android. Each version of Security Patch will have different (Minor) Encrypt algorithm. (change monthly. EG: July 4, July 19 will have same algorithm)
So, TWRP must have the same Security Patch as your current ROM on the phone to Decrypt Data Encrypted by that ROM.
What is my current security patch?On phone, go: Settings > About Phone, scroll down, you will see current security patch. If not, go: Settings > About Phone > Android Version.
Don't care about date of security patch, just care about month.
I'm just encrypt but not set any Password and TWRP keep asking to decrypt?Use "default_password" to decrypt.
What is the password to decrypt?Same as your lockscreen PIN/Password/Pattern.
I'm using PIN but TWRP always ask for Pattern. How to decrypt?In TWRP, go to Terminal. To decrypt, type in the terminal: "twrp decrypt <Password/PIN>" and tap Enter.
Note: <Password/PIN> is your lockscreen Password/PIN.
EG: My lockscreen PIN is 4294967296129009, I will type "twrp decrypt 4294967296129009" in the terminal and press enter.
Can I Backup my data when I forgot my Password to decrypt Data.?No.
What is SAR and non-SAR recovery?SAR: Makes System partition as Root.
non-SAR: Normal version, nothing changes.
Android 10 ROMs are SAR, some are non-SAR but can't use old tweaks that modify /System folder because it does not exist. Android 9 ROMs are non-SAR.
Use SAR recovery for SAR ROMs, non-SAR recovery for normal ROMs.
If anyone have question, just reply to the thread, I will answer as much as possible and put it in the second post.
Latest TWRP for ASUS ZenFone Max Pro M1Stock Oreo 334 --> 340 & LineageOS 15.1:
Source / Mirror
Pie May Security Patch:
Source / Mirror
Pie June --> August Security Patch:
Source / Mirror
Pie September --> May 2020 Security Patch:
Source / Mirror
Android Q SAR: (No decrypt)
Source / Mirror
TWRP Mods:
OrangeFox (by gourabpa):
Thread
Pitch Black (by akshat2012):
Thread
SkyHawk (by gourabpa)
Thread
Note:
1. These TWRPs is not my work, I'm just collect links for you for easy download.
So, all credit is to:
KrasCGQ (Oreo and Pie May Security Patch)
alex9yust (Pie September --> August)
Cecell3000 (September --> Feb 2020)
SagarMakhar (SAR Build)
2. Why do I reupload it on my drive? To backup. If the owner delete these files, I will not able to download it again and continue sharing.
Asked Question:
By AVinaSh_S
If Android 10 Beta is SAR then it will not support old Magisk Modules using /system correct me if mistaken.
Also what about disabling the force encryption in Android 10. How to do it.
Click to expand...
Click to collapse
- Yes, you cannot use Magisk Module or any old mod that modifies /system because it doesn't exist. To disable encryption, just format Data Partition normally using TWRP. (Don't use rm -rf)
Thanks for the detail post.
Question : If Android 10 Beta is SAR then it will not support old Magisk Modules using /system correct me if mistaken.
Also what about disabling the force encryption in Android 10. How to do it.
AVinaSh_S said:
Thanks for the detail post.
Question : If Android 10 Beta is SAR then it will not support old Magisk Modules using /system correct me if mistaken.
Also what about disabling the force encryption in Android 10. How to do it.
Click to expand...
Click to collapse
Yes, you cannot use Magisk Module or any mod that modifies /system because it doesn't exist. To disable encryption, just format Data Partition normally using TWRP. (Don't use rm -rf)
Sent from my ZenFone Max Pro M1 using XDA Labs
RedGreenBlue123 said:
Yes, you cannot use Magisk Module or any mod that modifies /system because it doesn't exist. To disable encryption, just format Data Partition normally using TWRP. (Don't use rm -rf)
Sent from my ZenFone Max Pro M1 using XDA Labs
Click to expand...
Click to collapse
Thank you .. so after each OTA update, I will need to format data each time if I do not want to use encryption?
AVinaSh_S said:
Thank you .. so after each OTA update, I will need to format data each time if I do not want to use encryption?
Click to expand...
Click to collapse
Yes. But you can disable force encryption by magisk. Open Magisk Manager, expand Advanced Settings, untick Preserve force encryption and dm-verity. Now, you didn't need to do a clean install every update.
Sent from my ZenFone Max Pro M1 using Tapatalk
I don't set any screen lock pin,
Tried twrp decrypt command, but still i am not able to get rid of problem
I flashed 059 firmware from official asus site, then flash decrypt zip for pie, after that this problem arises,
Using latest twrp recovery 3.3.1-0
ramansehra said:
I don't set any screen lock pin,
Tried twrp decrypt command, but still i am not able to get rid of problem
I flashed 059 firmware from official asus site, then flash decrypt zip for pie, after that this problem arises,
Using latest twrp recovery 3.3.1-0
Click to expand...
Click to collapse
twrp decrypt default_password
Make sure you have a correct TWRP that match the security patch.
Sent from my ZenFone Max Pro M1 using Tapatalk
RedGreenBlue123 said:
twrp decrypt default_password
Make sure you have a correct TWRP that match the security patch.
Click to expand...
Click to collapse
Currently I installed AEX ROM based on android 10,
Its security patch is 05 Feb,tried android Q twrp,
060 January twrp, 060 Feb twrp, but same problem persists,tried decrypt command in every twrp,
But still data is encrypted,
Do I need to install decrypt zip for android Q also.
ramansehra said:
Currently I installed AEX ROM based on android 10,
Its security patch is 05 Feb,tried android Q twrp,
060 January twrp, 060 Feb twrp, but same problem persists,tried decrypt command in every twrp,
But still data is encrypted,
Do I need to install decrypt zip for android Q also.
Click to expand...
Click to collapse
1. There are no TWRP to decrypt Android 10 now.
2. TWRP Decrypt is like explore an encrypted Data Partition, cannot fully decrypt it to unencrypted.
RedGreenBlue123 said:
1. There are no TWRP to decrypt Android 10 now.
2. TWRP Decrypt is like explore an encrypted Data Partition, cannot fully decrypt it to unencrypted.
Click to expand...
Click to collapse
I want to revert to stock ROM agian ,but problem is there of data encryption.
How to flash stock ROM ROM again?
ramansehra said:
I want to revert to stock ROM agian ,but problem is there of data encryption.
How to flash stock ROM ROM again?
Click to expand...
Click to collapse
1. Download TWRP flashable stock ROM to your computer.
2. Format Data Partition
3. Unmount Data then Mount again
4. Enable MTP
5. Copy stock to the phone
6. Install stock
Sent from my ZenFone Max Pro M1 using Tapatalk
Jan 2020 security patch is out
Sent from my ZenFone Max Pro M1 using XDA Labs
can you please upload the april 4 security patch twrp
After installing Pixel Experience now i cant Encrypt my Device
After installing Pixel Experience Plus now i cant Encrypt My device. I'm using Asus Zenfone Max Pro M1 Pleas Help me
Help and guidance needed. Noob here.
Bootloader unlocked. On stock pie rom. Build No: 087.
I want to flash PR10 or PR11.
Ive downloaded twrp for pie september patch.
Do we still need “decrypt.zip” and “Disable_Dm-Verity_ForceEncrypt_12.16.2018.zip” ?
Is this step correct?
1. Put phone in fastboot mode.
2. Enter fastboot flash recovery command.
3. Straight boot to recovery.
4. Install dm_verity and decrypt.
5. Flash Rom.
6. Reboot.
Pls help...
Hi every body, i'm trying to root mi 9T with QFJEUXM 11.0.4.0.
bootloader is unlocked
TRWP is installed
but when i install the magisk zip ( that override my boot), my phone doesn't want to boot anymore)
Note that I rooted the phone with the previous rom (android 9) successfully.
anyone have a solution for me?
thanks
Are u using the most recent version of magisk? I was succsefull at rooting 11.0.4.0 with versin 20.3.
tidus25 said:
Hi every body, i'm trying to root mi 9T with QFJEUXM 11.0.4.0.
bootloader is unlocked
TRWP is installed
but when i install the magisk zip ( that override my boot), my phone doesn't want to boot anymore)
Note that I rooted the phone with the previous rom (android 9) successfully.
anyone have a solution for me?
thanks
Click to expand...
Click to collapse
It is possible with no problems. Answering here right from the rooted Mi 9T QFJEUXM 11.0.4.0
Actually, you don't need TWRP to install Magisk. Just follow OP posts (also my posts - they are specifically about QFJEUXM 11.0.4.0) in the following two threads:
https://forum.xda-developers.com/mi-9t/how-to/guide-easiest-to-root-twrp-t4000209
https://forum.xda-developers.com/mi-9t/how-to/root-k20-indian-rom-v10-3-6-0-twrp-t3958566
In short, you need to patch from Magisk Manager the boot image extracted from Recovery/ZIP QFJEUXM 11.0.4.0 and then flash it from Fastboot.
Instead of patching yourself, you can use the patched boot image for QFJEUXM 11.0.4.0 from my Mega:
https://mega.nz/#F!hllnSIpA!amAG8moMYW_tG8r731Tzgg
So you don't need TWRP to install Magisk but you can independently install TWRP (e.g., upon installing Magisk). It's good to have if you ever install a Magisk module causing bootloop, you can then just remove that module in TWRP from /data/adb/modules and reboot to the previously rooted and working setup
Use the official TWRP from:
https://dl.twrp.me/davinci/twrp-3.3.1-0-davinci.img
For official TWRP do not format or wipe anything like VBMeta, Data, Persist or whatever; except, if you wish, Dalwik and Cache
Official TWRP supports encryption - when you boot to TWRP, just ype in your Android unlock pass/pin.
Same holds for OrangeFox custom recovery - you can install its zip from TWRP