Hi, I was looking to build Nougat for my device and try it and have some fun, but after getting all the files that the CyanogenMod build guide said that I should get, I ended with build errors (I think that are related to building the kernel.) Could anyone help me?
PS. I'd be happy to provide any extra info that you may need to diagnose and solve the problem.
Code:
[ 1% 878/46349] Building Kernel
make: Entering directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
GEN /home/charles/MCMNugget/out/target/product/clark/obj/KERNEL_OBJ/Makefile
scripts/kconfig/conf --silentoldconfig Kconfig
kernel/irq/Kconfig:22:warning: leading whitespace ignored
drivers/usb/gadget/Kconfig:896:warning: defaults for choice values not supported
warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))
warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))
GEN /home/charles/MCMNugget/out/target/product/clark/obj/KERNEL_OBJ/Makefile
CHK include/generated/uapi/linux/version.h
CC scripts/mod/devicetable-offsets.s
GEN scripts/mod/devicetable-offsets.h
HOSTCC scripts/mod/file2alias.o
HOSTLD scripts/mod/modpost
Using /home/charles/MCMNugget/kernel/motorola/msm8992 as source for kernel
CHK include/generated/utsrelease.h
CALL /home/charles/MCMNugget/kernel/motorola/msm8992/scripts/checksyscalls.sh
CHK include/generated/compile.h
make[2]: 'arch/arm64/boot/Image' is up to date.
make: Leaving directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
Building DTBs
make: Entering directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
CC scripts/mod/devicetable-offsets.s
GEN scripts/mod/devicetable-offsets.h
HOSTCC scripts/mod/file2alias.o
HOSTLD scripts/mod/modpost
make[2]: Nothing to be done for 'dtbs'.
make[2]: Nothing to be done for 'dtbs'.
make: Leaving directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
Building Kernel Modules
make: Entering directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
GEN /home/charles/MCMNugget/out/target/product/clark/obj/KERNEL_OBJ/Makefile
CHK include/generated/uapi/linux/version.h
Using /home/charles/MCMNugget/kernel/motorola/msm8992 as source for kernel
CHK include/generated/utsrelease.h
CC scripts/mod/devicetable-offsets.s
GEN scripts/mod/devicetable-offsets.h
HOSTCC scripts/mod/file2alias.o
CALL /home/charles/MCMNugget/kernel/motorola/msm8992/scripts/checksyscalls.sh
HOSTLD scripts/mod/modpost
Building modules, stage 2.
MODPOST 2 modules
make: Leaving directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
make: Entering directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
INSTALL drivers/soc/qcom/msm_core_ctl.ko
INSTALL drivers/staging/qcacld-2.0/wlan.ko
DEPMOD 3.10.102-CM-g22bd33c
depmod: WARNING: /home/charles/MCMNugget/out/target/product/clark/obj/KERNEL_OBJ/../../system/lib/modules/3.10.102-CM-g22bd33c/kernel/drivers/soc/qcom/msm_core_ctl.ko needs unknown symbol module_layout
make: Leaving directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
ninja: build stopped: subcommand failed.
build/core/ninja.mk:148: recipe for target 'ninja_wrapper' failed
make: *** [ninja_wrapper] Error 1
make: Leaving directory '/home/charles/MCMNugget'
#### make failed to build some targets (02:35 (mm:ss)) ####
NoLimitCrafting said:
Hi, I was looking to build Nougat for my device and try it and have some fun, but after getting all the files that the CyanogenMod build guide said that I should get, I ended with build errors (I think that are related to building the kernel.) Could anyone help me?
PS. I'd be happy to provide any extra info that you may need to diagnose and solve the problem.
Code:
[ 1% 878/46349] Building Kernel
make: Entering directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
GEN /home/charles/MCMNugget/out/target/product/clark/obj/KERNEL_OBJ/Makefile
scripts/kconfig/conf --silentoldconfig Kconfig
kernel/irq/Kconfig:22:warning: leading whitespace ignored
drivers/usb/gadget/Kconfig:896:warning: defaults for choice values not supported
warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))
warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))
GEN /home/charles/MCMNugget/out/target/product/clark/obj/KERNEL_OBJ/Makefile
CHK include/generated/uapi/linux/version.h
CC scripts/mod/devicetable-offsets.s
GEN scripts/mod/devicetable-offsets.h
HOSTCC scripts/mod/file2alias.o
HOSTLD scripts/mod/modpost
Using /home/charles/MCMNugget/kernel/motorola/msm8992 as source for kernel
CHK include/generated/utsrelease.h
CALL /home/charles/MCMNugget/kernel/motorola/msm8992/scripts/checksyscalls.sh
CHK include/generated/compile.h
make[2]: 'arch/arm64/boot/Image' is up to date.
make: Leaving directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
Building DTBs
make: Entering directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
CC scripts/mod/devicetable-offsets.s
GEN scripts/mod/devicetable-offsets.h
HOSTCC scripts/mod/file2alias.o
HOSTLD scripts/mod/modpost
make[2]: Nothing to be done for 'dtbs'.
make[2]: Nothing to be done for 'dtbs'.
make: Leaving directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
Building Kernel Modules
make: Entering directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
GEN /home/charles/MCMNugget/out/target/product/clark/obj/KERNEL_OBJ/Makefile
CHK include/generated/uapi/linux/version.h
Using /home/charles/MCMNugget/kernel/motorola/msm8992 as source for kernel
CHK include/generated/utsrelease.h
CC scripts/mod/devicetable-offsets.s
GEN scripts/mod/devicetable-offsets.h
HOSTCC scripts/mod/file2alias.o
CALL /home/charles/MCMNugget/kernel/motorola/msm8992/scripts/checksyscalls.sh
HOSTLD scripts/mod/modpost
Building modules, stage 2.
MODPOST 2 modules
make: Leaving directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
make: Entering directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
INSTALL drivers/soc/qcom/msm_core_ctl.ko
INSTALL drivers/staging/qcacld-2.0/wlan.ko
DEPMOD 3.10.102-CM-g22bd33c
depmod: WARNING: /home/charles/MCMNugget/out/target/product/clark/obj/KERNEL_OBJ/../../system/lib/modules/3.10.102-CM-g22bd33c/kernel/drivers/soc/qcom/msm_core_ctl.ko needs unknown symbol module_layout
make: Leaving directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
ninja: build stopped: subcommand failed.
build/core/ninja.mk:148: recipe for target 'ninja_wrapper' failed
make: *** [ninja_wrapper] Error 1
make: Leaving directory '/home/charles/MCMNugget'
#### make failed to build some targets (02:35 (mm:ss)) ####
Click to expand...
Click to collapse
I think you might be running into an external module that depends on another external module. Check this out. Section 6, particularly 6.3 could be pertinent to resolving this problem.
Take this with a heavy dose of skepticism. I'm just a tinkerer myself.
i think still needa wait until android N kernel sources code for pure
I would also look at the CM14 build of the moto pure also if you need to see how close yours is compared to CM.
ilovemeow said:
i think still needa wait until android N kernel sources code for pure
Click to expand...
Click to collapse
I'm using the cm-14.0 branch of the
CyanogenMod/android_kernel_motorola_msm8992
So technically it's out there, just in it's early stages.
jason2678 said:
[/HIDE]
I think you might be running into an external module that depends on another external module. Check this out. Section 6, particularly 6.3 could be pertinent to resolving this problem.
Take this with a heavy dose of skepticism. I'm just a tinkerer myself.
Click to expand...
Click to collapse
Thanks, I'll be sure to check it out
barakisbrown said:
I would also look at the CM14 build of the moto pure also if you need to see how close yours is compared to CM.
Click to expand...
Click to collapse
All of the CM projects that I'm using are on the cm-14.0 or staging/cm-14.0 branch
And I don't believe there has been other CM 14 builds of the MXP. If there has been though, I would greatly appreciate if you brought them to my attention.
ilovemeow said:
i think still needa wait until android N kernel sources code for pure
Click to expand...
Click to collapse
Moto releasing N and the sources would certainly aid development, but it isn't 100% necessary. Where there's a will, there's a way. I have a couple of old devices that Crapsung and LG abandoned at kitkat that are currently rocking fully functional marshmallow.
---------- Post added at 11:26 AM ---------- Previous post was at 11:24 AM ----------
NoLimitCrafting said:
All of the CM projects that I'm using are on the cm-14.0 or staging/cm-14.0 branch
And I don't believe there has been other CM 14 builds of the MXP. If there has been though, I would greatly appreciate if you brought them to my attention.
Click to expand...
Click to collapse
Hashbang has posted a few CM 14 builds to androidfilehost. General buzz is that they're booting, but no sim and maybe more than a little janky. Haven't tested myself. You might want to poke around his github.
Good luck.
NoLimitCrafting said:
Hi, I was looking to build Nougat for my device and try it and have some fun, but after getting all the files that the CyanogenMod build guide said that I should get, I ended with build errors (I think that are related to building the kernel.) Could anyone help me?
PS. I'd be happy to provide any extra info that you may need to diagnose and solve the problem.
Code:
[ 1% 878/46349] Building Kernel
make: Entering directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
GEN /home/charles/MCMNugget/out/target/product/clark/obj/KERNEL_OBJ/Makefile
scripts/kconfig/conf --silentoldconfig Kconfig
kernel/irq/Kconfig:22:warning: leading whitespace ignored
drivers/usb/gadget/Kconfig:896:warning: defaults for choice values not supported
warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))
warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))
GEN /home/charles/MCMNugget/out/target/product/clark/obj/KERNEL_OBJ/Makefile
CHK include/generated/uapi/linux/version.h
CC scripts/mod/devicetable-offsets.s
GEN scripts/mod/devicetable-offsets.h
HOSTCC scripts/mod/file2alias.o
HOSTLD scripts/mod/modpost
Using /home/charles/MCMNugget/kernel/motorola/msm8992 as source for kernel
CHK include/generated/utsrelease.h
CALL /home/charles/MCMNugget/kernel/motorola/msm8992/scripts/checksyscalls.sh
CHK include/generated/compile.h
make[2]: 'arch/arm64/boot/Image' is up to date.
make: Leaving directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
Building DTBs
make: Entering directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
CC scripts/mod/devicetable-offsets.s
GEN scripts/mod/devicetable-offsets.h
HOSTCC scripts/mod/file2alias.o
HOSTLD scripts/mod/modpost
make[2]: Nothing to be done for 'dtbs'.
make[2]: Nothing to be done for 'dtbs'.
make: Leaving directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
Building Kernel Modules
make: Entering directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
GEN /home/charles/MCMNugget/out/target/product/clark/obj/KERNEL_OBJ/Makefile
CHK include/generated/uapi/linux/version.h
Using /home/charles/MCMNugget/kernel/motorola/msm8992 as source for kernel
CHK include/generated/utsrelease.h
CC scripts/mod/devicetable-offsets.s
GEN scripts/mod/devicetable-offsets.h
HOSTCC scripts/mod/file2alias.o
CALL /home/charles/MCMNugget/kernel/motorola/msm8992/scripts/checksyscalls.sh
HOSTLD scripts/mod/modpost
Building modules, stage 2.
MODPOST 2 modules
make: Leaving directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
make: Entering directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
INSTALL drivers/soc/qcom/msm_core_ctl.ko
INSTALL drivers/staging/qcacld-2.0/wlan.ko
DEPMOD 3.10.102-CM-g22bd33c
depmod: WARNING: /home/charles/MCMNugget/out/target/product/clark/obj/KERNEL_OBJ/../../system/lib/modules/3.10.102-CM-g22bd33c/kernel/drivers/soc/qcom/msm_core_ctl.ko needs unknown symbol module_layout
make: Leaving directory '/home/charles/MCMNugget/kernel/motorola/msm8992'
ninja: build stopped: subcommand failed.
build/core/ninja.mk:148: recipe for target 'ninja_wrapper' failed
make: *** [ninja_wrapper] Error 1
make: Leaving directory '/home/charles/MCMNugget'
#### make failed to build some targets (02:35 (mm:ss)) ####
Click to expand...
Click to collapse
I also have been trying to build the rom and i also have the same error as you. I think its on thr kernel side. I peaked at @Hashbang173 github and i dont see that he forked over cm's kernel, but i could be wrong. Maybe he can assist both of us on this.
thank for your effortmate
LARMYV said:
I also have been trying to build the rom and i also have the same error as you. I think its on thr kernel side. I peaked at @Hashbang173 github and i dont see that he forked over cm's kernel, but i could be wrong. Maybe he can assist both of us on this.
Click to expand...
Click to collapse
I'm going to try to install his build of CM 14 and check the kernel from device settings, but if you know the kernel version, that would help save some time.
NoLimitCrafting said:
I'm going to try to install his build of CM 14 and check the kernel from device settings, but if you know the kernel version, that would help save some time.
Click to expand...
Click to collapse
Yeah thats my problem. His kernel on his github account says mm6.0 amd i dont see the 7.0 version.
LARMYV said:
Yeah thats my problem. His kernel on his github account says mm6.0 amd i dont see the 7.0 version.
Click to expand...
Click to collapse
Interesting, I'll look into it
LARMYV said:
Yeah thats my problem. His kernel on his github account says mm6.0 amd i dont see the 7.0 version.
Click to expand...
Click to collapse
I just tried installing and using the ROM and I saw this in device settings. If I'm not mistaken, the kernel is the same version provided by CyanogenMod's GitHub. It's very possible that made some modifications to make it work. Or I'm just doing something very wrong when it comes to building CM-14 ROMs.
NoLimitCrafting said:
I just tried installing and using the ROM and I saw this in device settings. If I'm not mistaken, the kernel is the same version provided by CyanogenMod's GitHub. It's very possible that made some modifications to make it work. Or I'm just doing something very wrong when it comes to building CM-14 ROMs.
Click to expand...
Click to collapse
I think he made some modifications to the kernel, but I dont know what he did.
LARMYV said:
I think he made some modifications to the kernel, but I dont know what he did.
Click to expand...
Click to collapse
Are you guys using the right hardware repos? Look at the staging branches.
And if you look at the kernel history and their gerrit you'll find everything you need to build it.
jbats said:
Are you guys using the right hardware repos? Look at the staging branches.
And if you look at the kernel history and their gerrit you'll find everything you need to build it.
Click to expand...
Click to collapse
Sorry for my awful response time
But if I were to build the kernel, do you know how I would then tell the compiler to not build the kernel again when doing "brunch clark"? Or would it automatically not build the kernel?
Related
Would you help me make sense of the make output below? Does this mean I was not able to build all the modules? I believe I only got one module, and given the errors below, I don't think the file is a valid working target. How do I fix this error please?
correctly?
[email protected]:~/WORKING_DIRECTORY$ make CFLAGS_MODULE=-fno-pic modules
scripts/kconfig/conf --silentoldconfig Kconfig
sound/soc/codecs/audience/Kconfig:40:warning: type of 'SND_SOC_ES_SLIM' redefined from 'boolean' to 'tristate'
sound/soc/codecs/audience/Kconfig:43:warning: type of 'SND_SOC_ES_I2C' redefined from 'boolean' to 'tristate'
sound/soc/codecs/audience/Kconfig:44:warning: choice value used outside its choice group
sound/soc/codecs/audience/Kconfig:41:warning: choice value used outside its choice group
CHK include/linux/version.h
CHK include/generated/utsrelease.h
make[1]: `include/generated/mach-types.h' is up to date.
CC arch/arm/kernel/asm-offsets.s
GEN include/generated/asm-offsets.h
CALL scripts/checksyscalls.sh
HOSTCC scripts/genksyms/genksyms.o
SHIPPED scripts/genksyms/lex.lex.c
SHIPPED scripts/genksyms/keywords.hash.c
SHIPPED scripts/genksyms/parse.tab.h
HOSTCC scripts/genksyms/lex.lex.o
SHIPPED scripts/genksyms/parse.tab.c
HOSTCC scripts/genksyms/parse.tab.o
HOSTLD scripts/genksyms/genksyms
CC scripts/mod/empty.o
MKELF scripts/mod/elfconfig.h
HOSTCC scripts/mod/file2alias.o
HOSTCC scripts/mod/modpost.o
HOSTCC scripts/mod/sumversion.o
HOSTLD scripts/mod/modpost
CC [M] drivers/scsi/scsi_wait_scan.o
Building modules, stage 2.
MODPOST 1 modules
ERROR: "module_layout" [drivers/scsi/scsi_wait_scan.ko] undefined!
ERROR: "__aeabi_unwind_cpp_pr0" [drivers/scsi/scsi_wait_scan.ko] undefined!
ERROR: "__aeabi_unwind_cpp_pr1" [drivers/scsi/scsi_wait_scan.ko] undefined!
ERROR: "scsi_complete_async_scans" [drivers/scsi/scsi_wait_scan.ko] undefined!
ERROR: "wait_for_device_probe" [drivers/scsi/scsi_wait_scan.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
[email protected]:~/WORKING_DIRECTORY$
What source are you using, and why do you need to build Samsung modules from source?
In addition to previous poster's questions:
Are talking about Xposed modules here?
And what ROM?
I got it from opensource.samsung.com. I am trying to add to the modules. I have to appologize; I may not have answered your question. If there is a specific version number or what not I can look up, please let me know so I can provide it.
Morningstar said:
What source are you using, and why do you need to build Samsung modules from source?
Click to expand...
Click to collapse
I apologize I do not know the difference between exposed vs. other kinds of modules. Could you please elaborate? What I did was to unpack the Kernel.tar.gz and Platform.tar.gz; I downloaded the version of AOSP metioned in the readme file. I set the environment settings as instructed in the readme files and configred the Makefile with the right CROSS_COMPILE setting. I then ran make successfully. Looked for *.ko files, and did not find a single one. Then I issued make module, and it stated to enable dynamic loadable modules. So I did that using menuconfig or xconfig; I have to check. Then I ran make modules, and I got the following errors:
Code:
[email protected]:~/WORKING_DIRECTORY$ make modules
scripts/kconfig/conf --silentoldconfig Kconfig
sound/soc/codecs/audience/Kconfig:40:warning: type of 'SND_SOC_ES_SLIM' redefined from 'boolean' to 'tristate'
sound/soc/codecs/audience/Kconfig:43:warning: type of 'SND_SOC_ES_I2C' redefined from 'boolean' to 'tristate'
sound/soc/codecs/audience/Kconfig:44:warning: choice value used outside its choice group
sound/soc/codecs/audience/Kconfig:41:warning: choice value used outside its choice group
CHK include/linux/version.h
CHK include/generated/utsrelease.h
make[1]: `include/generated/mach-types.h' is up to date.
CC arch/arm/kernel/asm-offsets.s
GEN include/generated/asm-offsets.h
CALL scripts/checksyscalls.sh
CC [M] drivers/scsi/scsi_wait_scan.o
Building modules, stage 2.
MODPOST 1 modules
ERROR: "__aeabi_unwind_cpp_pr0" [drivers/scsi/scsi_wait_scan.ko] undefined!
ERROR: "__aeabi_unwind_cpp_pr1" [drivers/scsi/scsi_wait_scan.ko] undefined!
ERROR: "scsi_complete_async_scans" [drivers/scsi/scsi_wait_scan.ko] undefined!
ERROR: "wait_for_device_probe" [drivers/scsi/scsi_wait_scan.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
Someguyfromhell said:
In addition to previous poster's questions:
Are talking about Xposed modules here?
And what ROM?
Click to expand...
Click to collapse
Can this voltage and current regulators enable 5V for OTG support:
http://postimg.org/image/5tz9sq3k1/
http://postimg.org/image/cjkigpqwx/
http://postimg.org/image/3vykulf9d/
It will be nice - if you add it to the kernel.
The new kernel is coming ?
I tried do a new but always ERROR 2 in Ubuntu
nalas said:
It will be nice - if you add it to the kernel.
The new kernel is coming ?
I tried do a new but always ERROR 2 in Ubuntu
Click to expand...
Click to collapse
I also have error.
When I run command make -j3 I get error:
scripts/kconfig/conf --silentoldconfig Kconfig
sound/soc/codecs/audience/Kconfig:40:warning: type of 'SND_SOC_ES_SLIM' redefined from 'boolean' to 'tristate'
sound/soc/codecs/audience/Kconfig:43:warning: type of 'SND_SOC_ES_I2C' redefined from 'boolean' to 'tristate'
sound/soc/codecs/audience/Kconfig:44:warning: choice value used outside its choice group
sound/soc/codecs/audience/Kconfig:41:warning: choice value used outside its choice group
warning: (SND_SOC_MSM8226) selects DOLBY_DAP which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && SND_SOC_MSM8974)
warning: (SND_SOC_MSM8226) selects DOLBY_DAP which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && SND_SOC_MSM8974)
CHK include/linux/version.h
CHK include/generated/utsrelease.h
make[1]: Nothing to be done for 'arch/arm/boot/dtbs'.
make[1]: 'include/generated/mach-types.h' is up to date.
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
CC arch/arm/mach-msm/board-dt.o
CC arch/arm/mach-msm/sec-switch.o
LD drivers/base/regmap/built-in.o
LD drivers/base/built-in.o
arch/arm/mach-msm/sec-switch.c:818:16: error: redefinition of 'midas_switch_show_vbus'
arch/arm/mach-msm/sec-switch.c:226:16: note: previous definition of 'midas_switch_show_vbus' was here
arch/arm/mach-msm/sec-switch.c:838:16: error: redefinition of 'midas_switch_store_vbus'
arch/arm/mach-msm/sec-switch.c:246:16: note: previous definition of 'midas_switch_store_vbus' was here
arch/arm/mach-msm/sec-switch.c:884:1: error: redefinition of 'dev_attr_disable_vbus'
arch/arm/mach-msm/sec-switch.c:292:1: note: previous definition of 'dev_attr_disable_vbus' was here
arch/arm/mach-msm/sec-switch.c:940:21: error: redefinition of 'sec_booster'
arch/arm/mach-msm/sec-switch.c:348:21: note: previous definition of 'sec_booster' was here
arch/arm/mach-msm/sec-switch.c:946:19: error: redefinition of 'midas_sec_switch_init'
arch/arm/mach-msm/sec-switch.c:354:19: note: previous definition of 'midas_sec_switch_init' was here
arch/arm/mach-msm/sec-switch.c:983:5: error: redefinition of 'current_cable_type'
arch/arm/mach-msm/sec-switch.c:391:5: note: previous definition of 'current_cable_type' was here
arch/arm/mach-msm/sec-switch.c: In function 'max77804k_muic_mhl_cb':
arch/arm/mach-msm/sec-switch.c:1235:18: error: 'MAX77804K_MUIC_ATTACHED' undeclared (first use in this function)
arch/arm/mach-msm/sec-switch.c:1235:18: note: each undeclared identifier is reported only once for each function it appears in
arch/arm/mach-msm/sec-switch.c: At top level:
arch/arm/mach-msm/sec-switch.c:1348:8: error: variable 'max77804k_muic' has initializer but incomplete type
arch/arm/mach-msm/sec-switch.c:1349:2: error: unknown field 'usb_cb' specified in initializer
arch/arm/mach-msm/sec-switch.c:1349:2: warning: excess elements in struct initializer [enabled by default]
error, forbidden warning: sec-switch.c:1349
scripts/Makefile.build:307: recipe for target 'arch/arm/mach-msm/sec-switch.o' failed
make[1]: *** [arch/arm/mach-msm/sec-switch.o] Error 1
Makefile:950: recipe for target 'arch/arm/mach-msm' failed
make: *** [arch/arm/mach-msm] Error 2
make: *** Waiting for unfinished jobs....
CC sound/soc/codecs/wcd9306.o
CC sound/soc/codecs/wcd9306-tables.o
CC sound/soc/codecs/wcd9xxx-resmgr.o
LD drivers/gpio/built-in.o
CC sound/soc/codecs/wcd9xxx-mbhc.o
LD drivers/leds/built-in.o
LD drivers/input/touchscreen/built-in.o
LD drivers/input/built-in.o
LD sound/soc/codecs/snd-soc-wcd9306.o
LD sound/soc/codecs/snd-soc-msm-stub.o
LD sound/soc/codecs/built-in.o
CC sound/soc/msm/msm8226.o
CC drivers/mfd/sm501.o
CC drivers/misc/max77888-muic.o
CC sound/soc/msm/qdsp6v2/msm-dai-q6-v2.o
CC drivers/mfd/tps65010.o
CC drivers/mfd/twl-core.o
LD sound/soc/msm/qdsp6v2/snd-soc-qdsp6v2.o
CC drivers/misc/max77828-muic.o
LD sound/soc/msm/qdsp6v2/built-in.o
CC drivers/mfd/twl4030-irq.o
LD sound/soc/msm/snd-soc-qdsp6v2.o
LD sound/soc/msm/snd-soc-msm8226.o
LD sound/soc/msm/snd-soc-hostless-pcm.o
LD sound/soc/msm/built-in.o
CC drivers/mfd/twl6030-irq.o
LD sound/soc/built-in.o
LD sound/built-in.o
CC drivers/mfd/twl4030-madc.o
LD drivers/misc/built-in.o
drivers/misc/max77828-muic.o: In function `get_switch_sel':
/home/toor/Desktop/GT-I9301I_KK_Opensource/Kernel/drivers/misc/max77828-muic.c:223: multiple definition of `get_switch_sel'
drivers/misc/max77888-muic.o:/home/toor/Desktop/GT-I9301I_KK_Opensource/Kernel/drivers/misc/max77888-muic.c:205: first defined here
drivers/misc/max77828-muic.o: In function `powered_otg_control':
/home/toor/Desktop/GT-I9301I_KK_Opensource/Kernel/drivers/misc/max77828-muic.c:1854: multiple definition of `powered_otg_control'
drivers/misc/max77888-muic.o:/home/toor/Desktop/GT-I9301I_KK_Opensource/Kernel/drivers/misc/max77888-muic.c:1951: first defined here
drivers/misc/max77828-muic.o: In function `muic_otg_control':
/home/toor/Desktop/GT-I9301I_KK_Opensource/Kernel/drivers/misc/max77828-muic.c:1845: multiple definition of `muic_otg_control'
drivers/misc/max77888-muic.o:/home/toor/Desktop/GT-I9301I_KK_Opensource/Kernel/drivers/misc/max77888-muic.c:1942: first defined here
CC drivers/mfd/twl4030-power.o
scripts/Makefile.build:375: recipe for target 'drivers/misc/built-in.o' failed
make[2]: *** [drivers/misc/built-in.o] Error 1
scripts/Makefile.build:443: recipe for target 'drivers/misc' failed
make[1]: *** [drivers/misc] Error 2
make[1]: *** Waiting for unfinished jobs....
CC drivers/mfd/ezx-pcap.o
CC drivers/mfd/wcd9xxx-core.o
drivers/mfd/ezx-pcap.c: In function 'pcap_isr_work':
drivers/mfd/ezx-pcap.c:205:2: error: implicit declaration of function 'irq_to_gpio' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
scripts/Makefile.build:307: recipe for target 'drivers/mfd/ezx-pcap.o' failed
make[2]: *** [drivers/mfd/ezx-pcap.o] Error 1
make[2]: *** Waiting for unfinished jobs....
scripts/Makefile.build:443: recipe for target 'drivers/mfd' failed
make[1]: *** [drivers/mfd] Error 2
Makefile:950: recipe for target 'drivers' failed
make: *** [drivers] Error 2
Error 2 - too.
I think this is problem with some path .
I have everythink installed what is nessesary.
nalas said:
Error 2 - too.
I think this is problem with some path .
I have everythink installed what is nessesary.
Click to expand...
Click to collapse
Do you know how to solve this problem?
not yet I still looking for it in google but every video have not this problem
nalas said:
not yet I still looking for it in google but every video have not this problem
Click to expand...
Click to collapse
Does this have to be installed?
Current Minimal Requirements
============================
Upgrade to at *least* these software revisions before thinking you've
encountered a bug! If you're unsure what version you're currently
running, the suggested command should tell you.
Again, keep in mind that this list assumes you are already functionally
running a Linux kernel. Also, not all tools are necessary on all
systems; obviously, if you don't have any ISDN hardware, for example,
you probably needn't concern yourself with isdn4k-utils.
o Gnu C 3.2 # gcc --version
o Gnu make 3.80 # make --version
o binutils 2.12 # ld -v
o util-linux 2.10o # fdformat --version
o module-init-tools 0.9.10 # depmod -V
o e2fsprogs 1.41.4 # e2fsck -V
o jfsutils 1.1.3 # fsck.jfs -V
o reiserfsprogs 3.6.3 # reiserfsck -V
o xfsprogs 2.6.0 # xfs_db -V
o squashfs-tools 4.0 # mksquashfs -version
o btrfs-progs 0.18 # btrfsck
o pcmciautils 004 # pccardctl -V
o quota-tools 3.09 # quota -V
o PPP 2.4.0 # pppd --version
o isdn4k-utils 3.1pre1 # isdnctrl 2>&1|grep version
o nfs-utils 1.0.5 # showmount --version
o procps 3.2.0 # ps --version
o oprofile 0.9 # oprofiled --version
o udev 081 # udevd --version
o grub 0.93 # grub --version || grub-install --version
o mcelog 0.6 # mcelog --version
o iptables 1.4.2 # iptables -V
Yhx - I check it.
I have Ubuntu 16.04 LTS and GCC 5.0 - maybe not compatible ...
make: /opt/toolchains/arm-eabi-4.6/bin/arm-eabi-gcc: Command not found
CHK include/linux/version.h
CHK include/generated/utsrelease.h
HOSTCC scripts/basic/fixdep
make[1]: 'include/generated/mach-types.h' is up to date.
CC kernel/bounds.s
/bin/sh: 1: /opt/toolchains/arm-eabi-4.6/bin/arm-eabi-gcc: not found
/home/nala/S3NEO/kernel/./Kbuild:35: recipe for target 'kernel/bounds.s' failed
make[1]: *** [kernel/bounds.s] Error 127
Makefile:986: recipe for target 'prepare0' failed
make: *** [prepare0] Error 2
make: *** Waiting for unfinished jobs....
CC scripts/mod/empty.o
/bin/sh: 1: /opt/toolchains/arm-eabi-4.6/bin/arm-eabi-gcc: not found
scripts/Makefile.build:307: recipe for target 'scripts/mod/empty.o' failed
make[2]: *** [scripts/mod/empty.o] Error 127
scripts/Makefile.build:443: recipe for target 'scripts/mod' failed
make[1]: *** [scripts/mod] Error 2
Makefile:506: recipe for target 'scripts' failed
make: *** [scripts] Error 2
Did you select right directory of toolchain?
nalas said:
Yhx - I check it.
I have Ubuntu 16.04 LTS and GCC 5.0 - maybe not compatible ...
make: /opt/toolchains/arm-eabi-4.6/bin/arm-eabi-gcc: Command not found
CHK include/linux/version.h
CHK include/generated/utsrelease.h
HOSTCC scripts/basic/fixdep
make[1]: 'include/generated/mach-types.h' is up to date.
CC kernel/bounds.s
/bin/sh: 1: /opt/toolchains/arm-eabi-4.6/bin/arm-eabi-gcc: not found
/home/nala/S3NEO/kernel/./Kbuild:35: recipe for target 'kernel/bounds.s' failed
make[1]: *** [kernel/bounds.s] Error 127
Makefile:986: recipe for target 'prepare0' failed
make: *** [prepare0] Error 2
make: *** Waiting for unfinished jobs....
CC scripts/mod/empty.o
/bin/sh: 1: /opt/toolchains/arm-eabi-4.6/bin/arm-eabi-gcc: not found
scripts/Makefile.build:307: recipe for target 'scripts/mod/empty.o' failed
make[2]: *** [scripts/mod/empty.o] Error 127
scripts/Makefile.build:443: recipe for target 'scripts/mod' failed
make[1]: *** [scripts/mod] Error 2
Makefile:506: recipe for target 'scripts' failed
make: *** [scripts] Error 2
Click to expand...
Click to collapse
Did you select right directory?
Pavlex4 said:
Did you select right directory?
Click to expand...
Click to collapse
I check it again but I'vo copiet it from arm-eabi- (file path) - thx
nalas said:
I check it again but I'vo copiet it from arm-eabi- (file path) - thx
Click to expand...
Click to collapse
Does this errors appear because of gcc?
Pavlex4 said:
Does this errors appear because of gcc?
Click to expand...
Click to collapse
Do you know how to downgrade version of gcc???
Find on github - google it.
Wysłane z mojego SM-G935F przy użyciu Tapatalka
nalas said:
Find on github - google it.
Wysłane z mojego SM-G935F przy użyciu Tapatalka
Click to expand...
Click to collapse
Did you try to compile kernel with gcc 3.2???
I've been trying to compile kernel from samsung source for last few weeks but failed everytime.
At start everything goes fine almost. The problem is with the last step of compilation of the kernel.
Whenever I run the command:
HTML:
make -j5
it comes up with the error:
HTML:
scripts/kconfig/conf --silentoldconfig Kconfig
sound/soc/codecs/audience/Kconfig:40:warning: type of 'SND_SOC_ES_SLIM' redefined from 'boolean' to 'tristate'
sound/soc/codecs/audience/Kconfig:43:warning: type of 'SND_SOC_ES_I2C' redefined from 'boolean' to 'tristate'
boolean symbol SND_SOC_MAX98506 tested for 'm'? test forced to 'n'
sound/soc/codecs/audience/Kconfig:44:warning: choice value used outside its choice group
sound/soc/codecs/audience/Kconfig:41:warning: choice value used outside its choice group
CHK include/linux/version.h
CHK include/generated/utsrelease.h
make[1]: 'include/generated/mach-types.h' is up to date.
CC arch/arm/kernel/asm-offsets.s
In file included from include/linux/scatterlist.h:10:0,
from include/linux/dma-mapping.h:9,
from arch/arm/kernel/asm-offsets.c:15:
/media/sf_Krnl/Kernel/arch/arm/include/asm/io.h:30:26: fatal error: mach/msm_rtb.h: No such file or directory
#include <mach/msm_rtb.h>
^
compilation terminated.
/media/sf_Krnl/Kernel/./Kbuild:81: recipe for target 'arch/arm/kernel/asm-offsets.s' failed
make[1]: *** [arch/arm/kernel/asm-offsets.s] Error 1
Makefile:999: recipe for target 'prepare0' failed
make: *** [prepare0] Error 2
I've tried it a lot of times by changing directories, folder and terminals but nothing worked.
Further, I've used all these toolchians I mentioned here:
Code:
UBER Toolchian 7 (arm-eabi)
UBER toolchian 4.9 (arm-eabi)
NDK 4.9 (arm-eabi)
Sabermod 4.9 (arm-eabi)
linaro 4.9 (arm-eabi)
but all failed.
Help me please.
I tried to build kernel image using the toolchain the kernel , which I downloaded from htcdev, had in the README file :
defconfig file: msm8994_defconfig
Download:
========
Download the corresponding official android toolchain:
linux-x86:
git clone //android.googlesource.com/platform/prebuilts/gcc/linux-x86/aarch64/aarch64-linux-android-4.9( I downloaded this one)
darwin-x86:
git clone //android.googlesource.com/platform/prebuilts/gcc/darwin-x86/aarch64/aarch64-linux-android-4.9
Build the kernel:
=================
set the following environment variables:
$ mkdir -p out
$ make ARCH=arm64 CROSS_COMPILE=<path-to-toolchain>/bin/aarch64-linux-android- O=out msm8994_defconfig
$ make ARCH=arm64 CROSS_COMPILE=<path-to-toolchain>/bin/aarch64-linux-android- O=out -j16
Output binary files:
====================
After the build process finishes, the kernel image will be located at out/arch/arm64/boot/Image.gz-dtb
For additional information:
===========================
I modified the the kernel using the command : make menuconfig
After I modified it as the nethunter modifying the kernel section said.
I could not modify the SDR section because I did not have those options in the menuconfig
After that, I tried to compile, but this happened:
# make ARCH=arm64 CROSS_COMPILE=/root/nethunter/toolchain/bin/aarch64-linux-android- -j16
scripts/kconfig/conf --silentoldconfig Kconfig
warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))
warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
CC scripts/mod/devicetable-offsets.s
GEN scripts/mod/devicetable-offsets.h
HOSTCC scripts/mod/file2alias.o
CALL scripts/checksyscalls.sh
HOSTLD scripts/mod/modpost
CHK include/generated/compile.h
GZIP kernel/config_data.gz
CHK kernel/config_data.h
UPD kernel/config_data.h
CC kernel/configs.o
LD kernel/built-in.o
make[1]: Nothing to be done for 'dtbs'.
make[1]: Nothing to be done for 'dtbs'.
LD drivers/media/platform/msm/dvb/built-in.o
CC drivers/media/media-device.o
LD drivers/media/platform/msm/built-in.o
CC drivers/media/media-devnode.o
CC drivers/media/media-entity.o
LD drivers/media/platform/built-in.o
LD drivers/media/media.o
LD drivers/media/built-in.o
LD drivers/built-in.o
LINK vmlinux
LD vmlinux.o
MODPOST vmlinux.o
GEN .version
CHK include/generated/compile.h
UPD include/generated/compile.h
CC init/version.o
LD init/built-in.o
drivers/built-in.o: In function `btusb_probe':
/root/nethunter/kernel/drivers/bluetooth/btusb.c:1391: undefined reference to `get_rome_version'
/root/nethunter/kernel/drivers/bluetooth/btusb.c:1391.text+0x5e9e58): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `get_rome_version'
/root/nethunter/kernel/drivers/bluetooth/btusb.c:1400: undefined reference to `rome_download'
/root/nethunter/kernel/drivers/bluetooth/btusb.c:1400.text+0x5e9ea4): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `rome_download'
Makefile:814: recipe for target 'vmlinux' failed
make: *** [vmlinux] Error 1
I do not know what to do now. Can you please help me?
UPDATE
GhostCop1 said:
I tried to build kernel image using the toolchain the kernel , which I downloaded from htcdev, had in the README file :
defconfig file: msm8994_defconfig
Download:
========
Download the corresponding official android toolchain:
linux-x86:
git clone //android.googlesource.com/platform/prebuilts/gcc/linux-x86/aarch64/aarch64-linux-android-4.9( I downloaded this one)
darwin-x86:
git clone //android.googlesource.com/platform/prebuilts/gcc/darwin-x86/aarch64/aarch64-linux-android-4.9
Build the kernel:
=================
set the following environment variables:
$ mkdir -p out
$ make ARCH=arm64 CROSS_COMPILE=<path-to-toolchain>/bin/aarch64-linux-android- O=out msm8994_defconfig
$ make ARCH=arm64 CROSS_COMPILE=<path-to-toolchain>/bin/aarch64-linux-android- O=out -j16
Output binary files:
====================
After the build process finishes, the kernel image will be located at out/arch/arm64/boot/Image.gz-dtb
For additional information:
===========================
I modified the the kernel using the command : make menuconfig
After I modified it as the nethunter modifying the kernel section said.
I could not modify the SDR section because I did not have those options in the menuconfig
After that, I tried to compile, but this happened:
# make ARCH=arm64 CROSS_COMPILE=/root/nethunter/toolchain/bin/aarch64-linux-android- -j16
scripts/kconfig/conf --silentoldconfig Kconfig
warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))
warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
CC scripts/mod/devicetable-offsets.s
GEN scripts/mod/devicetable-offsets.h
HOSTCC scripts/mod/file2alias.o
CALL scripts/checksyscalls.sh
HOSTLD scripts/mod/modpost
CHK include/generated/compile.h
GZIP kernel/config_data.gz
CHK kernel/config_data.h
UPD kernel/config_data.h
CC kernel/configs.o
LD kernel/built-in.o
make[1]: Nothing to be done for 'dtbs'.
make[1]: Nothing to be done for 'dtbs'.
LD drivers/media/platform/msm/dvb/built-in.o
CC drivers/media/media-device.o
LD drivers/media/platform/msm/built-in.o
CC drivers/media/media-devnode.o
CC drivers/media/media-entity.o
LD drivers/media/platform/built-in.o
LD drivers/media/media.o
LD drivers/media/built-in.o
LD drivers/built-in.o
LINK vmlinux
LD vmlinux.o
MODPOST vmlinux.o
GEN .version
CHK include/generated/compile.h
UPD include/generated/compile.h
CC init/version.o
LD init/built-in.o
drivers/built-in.o: In function `btusb_probe':
/root/nethunter/kernel/drivers/bluetooth/btusb.c:1391: undefined reference to `get_rome_version'
/root/nethunter/kernel/drivers/bluetooth/btusb.c:1391.text+0x5e9e58): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `get_rome_version'
/root/nethunter/kernel/drivers/bluetooth/btusb.c:1400: undefined reference to `rome_download'
/root/nethunter/kernel/drivers/bluetooth/btusb.c:1400.text+0x5e9ea4): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `rome_download'
Makefile:814: recipe for target 'vmlinux' failed
make: *** [vmlinux] Error 1
I do not know what to do now. Can you please help me?
Click to expand...
Click to collapse
I've searched the web and I found this : (https//bugzilla.redhat.com/show_bug.cgi?id=124355
I think that it is a bug from the toolchain or binutils.
Good,but this forum is focused on M9+ shipped with MTK chipset (MT6795t).
Maybe you should go to the exact forum to get nice advice.
yvtc75 said:
Good,but this forum is focused on M9+ shipped with MTK chipset (MT6795t).
Maybe you should go to the exact forum to get nice advice.
Click to expand...
Click to collapse
Hi. Can you give me a link to the M9 forums, because I can not find them.
yvtc75 said:
Good,but this forum is focused on M9+ shipped with MTK chipset (MT6795t).
Maybe you should go to the exact forum to get nice advice.
Click to expand...
Click to collapse
Nevermind, found it. Thanks though.
Been a while ago, but for all who need it: also enable CONFIG_BT_ATH3K in kernel. "Atheros firmware download driver" in
-> Networking support (NET [=y])
-> Bluetooth subsystem support (BT [=y])
-> Bluetooth device drivers
I'm a beginner trying to compile source. I can't pass "make msm-perf_ailsa_ii_defconfig".
As the error suggests, the /vendor/ directory does not exist. But /qcom/Kconfig has the line,
Code:
source "drivers/soc/qcom/vendor/Kconfig"
. Thanks for any help.
Code:
[email protected]:~/kernel1/msm-3.18$ make clean
[email protected]:~/kernel1/msm-3.18$ make mrproper
[email protected]:~/kernel1/msm-3.18$ make msm-perf_ailsa_ii_defconfig
HOSTCC scripts/basic/fixdep
HOSTCC scripts/kconfig/conf.o
SHIPPED scripts/kconfig/zconf.tab.c
SHIPPED scripts/kconfig/zconf.lex.c
SHIPPED scripts/kconfig/zconf.hash.c
HOSTCC scripts/kconfig/zconf.tab.o
HOSTLD scripts/kconfig/conf
drivers/soc/qcom/Kconfig:836: can't open file "drivers/soc/qcom/vendor/Kconfig"
scripts/kconfig/Makefile:105: recipe for target 'msm-perf_ailsa_ii_defconfig' failed
make[1]: *** [msm-perf_ailsa_ii_defconfig] Error 1
Makefile:542: recipe for target 'msm-perf_ailsa_ii_defconfig' failed
make: *** [msm-perf_ailsa_ii_defconfig] Error 2
[email protected]:~/kernel1/msm-3.18$
That's because the source is broken. Even if you fix the compile errors it won't boot. You can thank ZTE for that.