Related
Well hello everyone.
I am an application development student from Belgium.
I am proficient in Java, VB.NET, some c/c++ and also PHP/JS/HTML/CSS
Anyways, my recent interest has been going out to creating custom roms for the galaxy S!
The problem now is though, I was able to find some guides and such, but most were incomplete, and for HTC(and other) devices.
I have no idea what is different between making a ROM for galaxy S or a ROM for an HTC device.
If anyone would like to link me to some good resources that can help me on my way, or would like to collaborate (and in the meanwhile teach me a bit) I would be more than happy! (I am open for collaboration as I am pretty proficient in Java and I'm always happy to code and learn more about coding!)
I think the question is really want you want to do!
Custom ROMs for Android are as simple as using recovery console to replace files on the system with your own versions.
ie. Replace the framework.apk which contains all theme images with your own modified one, which you can use to skin the device. Same for replacing other system apps.
Unfortunately, most of these apps are closed source, so modifying them is difficult. The stock android system has open source versions of most of them though, and you can modify those and build them, and then replace the ones on the device. I'm not entirely sure how to build them up though, but it probably isn't too hard.
Then there are custom kernels, which let you actually change the underlying linux system underneath android - Samsung has an open source version of the kernel available that you can compile, and then flash to your phone using Odin or other tools. Compiling the kernel is pretty tricky though.
Well i'm really talking about stuff like SamSet, MoDaCo, Doc's ROM and others.
I'm not saying I want to create a pro ROM in a day or anything, but i'd really love to learn more to get better (always looking for more stuff to put on the resume, I guess?!)
Thanks a lot,
Kenny
Bump for some help
(sorry for the double post but i'm really eager to learn)
I don't have time to give a detailed response right now. However you will want to read up on yaffs (file system) and odexing/deodexing ROMs.
Thank you I will definately do that,
I am following a guide now to start out creating custom ROMs for android, however it was written for Motorola Droid and I have no idea what you have to do different for a samsung galaxy s.
I am a good coder, even though I say so myself, with a lot of experience. I also have a lot of linux experience, you name it
Only the problem is the old, and much known "where do I get started?"
So if anyone can point me out in the right direction on that, tell me how/where you started out, I would appreciate it greatly!
Thanks!
Very sorry to bump again
I set up my environment in ubuntu today to get started (just gotta fix a few errors, didn't know android wouldn't compile on java 1.6, only on 1.5)
Anyways, still need some help here! thanks!
Again I am awefully sorry for the bump here but i'd really like some help.
Note that i'm not a newbie at coding whatsoever and i'm not unfamiliar with some hardcore java, c/c++ and other languages, I'm just having trouble getting started when it comes to modding an existing android release (there are tutorials on HTC and other devices but some methods do not apply to the galaxy S)
If you're trying to create a ROM from scratch then unfortunately you're out of luck at the moment. No one has really managed to do so yet. By "from scratch" I mean the Android Open Source Project (i.e. official Android git repository).
What you can do is grab an existing firmware. Extract the contents, de-odex the apks, modify them or add new apks, optionally you can also compile a custom SGS kernel using Samsung's kernel source. Then you can re-odex the ROM, pack it back up and distribute it.
There's no real "starting place" as such and you won't yet find any tutorials about how to create SGS ROMs. Just give it a go and see where you get.
Yes, I do mean creating a ROM from stock samsung firmware, of course.
So my next logical question would be now:
How do I go over extracting contents from the existing samsung firmware, de-odexing and so on?
Any links/guides/tips are greatly appreciated, as long as they are applicable to this cell phone and not totally crap, thanks!
Samsung uses rfs, I think you should know. There is a thread somewhere in this forum regarding extracting .rfs file. Understood you need Debian though.
For some readup, go search for a famous guy named JesusFreke. Tons of materials...
Hope that from here onwards, this can lead you on, and to find out more. Google is your friend too...
I'm afraid my biggest problems already occur in setting up the environment, so it's really the very beginning that gets me stuck, i'm sure coding would be a bikeride compared to setting up the environment for me (i'm no hero in linux,not at all, i'm afraid)
How the hell do I get from point A (being downloading the full source) to point B (starting to create a custom ROM?)
thanks
of course if anyone has the time, and wants to, you can PM me your msn or something, if anyone is up to it
Raykoid666 said:
I'm afraid my biggest problems already occur in setting up the environment, so it's really the very beginning that gets me stuck, i'm sure coding would be a bikeride compared to setting up the environment for me (i'm no hero in linux,not at all, i'm afraid)
How the hell do I get from point A (being downloading the full source) to point B (starting to create a custom ROM?)
thanks
of course if anyone has the time, and wants to, you can PM me your msn or something, if anyone is up to it
Click to expand...
Click to collapse
Agreed completely! Getting a full cross-compilation to Samsung's Android going is seriously difficult! There have been some promises for tutorials and guides for setting things up though, but none have appeared yet. Probably because it's hard!
Well thank you for agreeing with me on that.
I am really hoping for anyone that can help me out here, either on here or in private, and give some detailed instructions on how to get started.
Hell there is enough information on creating roms alread, deodexing, adding/removing apps etc etc etc... The real problem lies in setting everything up properly.
I think I have gotten to the point where I'm compiling the android source (without samsung specific files)
note i'm saying "i think i am compiling" because i'm hoping it won't error out on me again after an hour of compiling!
But once that is done... I have no idea where to go next, where to get the samsung specific files, or what to do with them whatsoever once i have them
thanks!
Android generic source won't actually help you much. Samsung has made a huge number of changes to it, and while it is all open source, backporting their changes to get your stock source running on the phone is a major undertaking. I believe cyanogenmod was actually working on this, but it seems without much success so far.
What the other rom makers you see are doing is taking a snapshot of a running rom, copying over all of the APKs and the files on a running device, and then tweaking those. ie. Opening up framework-res.apk and changing the image files inside.
The update.zip roms that are what most people are doing are really just using the Android recovery to replace files on the phone with their own versions. Since the underlying system is linux, and everything is a file, this actually works pretty well.
The kernel development effort is completely separate from the rest of the system though, and Samsung has provided the entire source tree that just has to be compiled. I'm a bit stumped myself on all the details of setting it up, but I have seen some threads on this forum about it, and it didn't seem too bad to set up. Apparently you shouldn't use the codesourcery toolchain though, or something. Not too clued up on it, sorry. Hopefully someone with the details can chime in, or give us a link to the old post on it (I'm failing to find it using the search function! )
Alright sounds good!
So these recovery files you are talking about (the contents of /system) how do i retrieve those from a base ROM such as JM7 or the likes after a clean flash?)
Raykoid666 said:
Alright sounds good!
So these recovery files you are talking about (the contents of /system) how do i retrieve those from a base ROM such as JM7 or the likes after a clean flash?)
Click to expand...
Click to collapse
Root your phone, zip them up onto the sdcard, and then copy them off.
There are probably better methods, but this works fine.
Also, with credits to Unhelpful, he has told me that the correct toolchain to be using is 'uClibc or eglibc toolchain with ct-ng'. I have no idea what to do with that yet, but it's a start.
RyanZA said:
Root your phone, zip them up onto the sdcard, and then copy them off.
There are probably better methods, but this works fine.
Also, with credits to Unhelpful, he has told me that the correct toolchain to be using is 'uClibc or eglibc toolchain with ct-ng'. I have no idea what to do with that yet, but it's a start.
Click to expand...
Click to collapse
You don't even need to root your phone to pull /system Ryan
adb pull /system <random folder>
is all you need ^^
Alright thank you, I managed to get all the /system files using abd pull /system
now next thing up would be de-odexing right, before I go editing stuff?
Now before I go de-odexing. Can anyone tell me what exactly de-odexing is and why I need it?
and what do I need to do to create an update.zip again?
thanks a lot all!
Tayutama said:
You don't even need to root your phone to pull /system Ryan
adb pull /system <random folder>
is all you need ^^
Click to expand...
Click to collapse
Haha cool, didn't know you could pull whole folders!
Raykoid666 said:
Alright thank you, I managed to get all the /system files using abd pull /system
now next thing up would be de-odexing right, before I go editing stuff?
Now before I go de-odexing. Can anyone tell me what exactly de-odexing is and why I need it?
and what do I need to do to create an update.zip again?
thanks a lot all!
Click to expand...
Click to collapse
The apk files in Android are odexed - that means they have a special index applied for dalvik that speeds them up somehow! I don't know how, I haven't checked how it actually works.
The important point is though:
odexed is faster, but you can't edit it because of signatures or something technical
deodexed means you can change it however you want
More useful info can be found from google - lots of it!
update.zip is easy - it's a zip file in a special format that can be understood by Android's recovery console. The easiest way to do it is to grab an existing update.zip and modify it as needed. Tayutama has millions of em around, so use his!
Then you need to sign it once you're finished with it so that the SGS will accept it. Samsung made a boo-boo and didn't disable the test keys for the 2.1 SGS firmwares. That makes it easy!
http://www.londatiga.net/it/how-to-sign-apk-zip-files/
Just use the test keys to sign it, and then copy it to /sdcard/update.zip and reboot into recovery and it'll work.
NOTE: This is a thread for the build devs.
Users who want to try this solution themselves should head over to TheAgent1982's thread: RTL Support Project, or go to the Hebrew guide at htcaddicts.com.
Update: Hey devs. Just so you'd know, we're even willing to do the framework.jar patching for you!
All we ask from you is to deodex your builds, and include the patched framework.jar (which appears to be almost the same for all builds, barring sense/non-sense differences).
PM if you're willing to let us help
Hey devs
First of all, thanks to all the devs who are doing a great work with everything!
There's one thing though that's a pox on all Android builds (even native android devices), and that is full-on right-to-left support. What do I mean?
Sure, there are Hebrew (and I assume Arabic) fonts in Android, and MOST applications work just fine, with the notable exceptions of Gmail, Google maps, and most native Google-apps, who all display Hebrew backwards.
A far more stressing issue, however, is that ALL android applications without exception display numbers backwards in right-to-left texts (so 10 becomes 01, 12 becomes 21, etc. It can get really confusing really fast).
Any way, there exists a solution for both these problems that can USUALLY be fixed with a medium amount of experience on native Android devices, but requires a bit of a hassle for HD2 owners.
Hopefully, you devs can incorporate this fix to future releases, once the fixed files are obtained it shouldn't be too hard to spread in the future.
Here's the process:
BTW, This only works on completely deodexed builds!
First, you have to download this zip file. It basically contains the fixed files and some other stuff you devs probably won't need.
The fix then involves extracting 'framework.jar' from the phone, and extracting the 'classes' file thusly:
Code:
java -jar baksmali-1.2.2.jar -o classes classes.dex
Then, in the subsequently created "classes" folder, you need to replace the files in "/classes/android/graphics/" and "classes/android/text" with the relevant files in the aforementioned zip file (from the corresponding folders, of course, under "files/froyo/")
After that is done, you need to re-create 'classes.dex' using:
Code:
java -Xmx512M -jar smali-1.2.2.jar classes -o classes_new.dex
Then, replace the old 'classes.dex' in 'framework.jar' with the new one (after renaming it back to 'classes.dex', of course), and push the new and fixed 'framework.jar' back to the phone.
Reboot, and voila: full-on Left-to-Right support!
I'm sure you devs have far better ways of including these fixed files without having to edit the entire thing every time, but what would I know?
We would be extremely appreciative to all you builds devs if you could incorporate those fixed 'classes' files in future builds, it'll save us a ton of work.
Also, if any of you guys also need volunteers for beta-testing this solution (as I'm sure you don't have Hebrew content to test it with), feel free to PM me.
Thank you for listening, and keep up the great work!
((PS, thanks to member silverbluem who helped simplify the process))
+1
i use the htc sense to read sms so
the msg wont appear word4 word3 word2 word1
+1 for that. although i am using bifbif ver 1.2 with CM6 and its OK here.
i've test it on Mdj Evolution 2.3 and it work perfect:
i never copied the files to /graphic only to /text folder
to put the Framework.jar in the device because we dont have recovery mode
use this commands:
to pull the file:
adb pull system/framework/framework.jar
install the attached files
adb push (your file location/framework.jar) system/framework/framework.jar
after putting the file restart the device
restart might take 5-10 min first run after applying the file
thanks
silverbluem said:
i've test it on Mdj Evolution 2.3 and it work perfect:
i never copied the files to /graphic only to /text folder
to put the Framework.jar in the device because we dont have recovery mode
use this commands:
to pull the file:
adb pull system/framework/framework.jar
install the attached files
adb push (your file location/framework.jar) system/framework/framework.jar
after putting the file restart the device
restart might take 5-10 min first run after applying the file
thanks
Click to expand...
Click to collapse
This sure does absolve us of needing to use Linux and needing all that messy system.ext2 stuff. I'll give it a try.
Still, it'd be nice to have these updated files already incorporated into future builds.
Ambious said:
This sure does absolve us of needing to use Linux and needing all that messy system.ext2 stuff. I'll give it a try.
Still, it'd be nice to have these updated files already incorporated into future builds.
Click to expand...
Click to collapse
still need to figure out how to replace the graphic file
cause the view is not perfect without it...
Ambious said:
Edit: I tried this method, and while it DID boot, the solution didn't work - numbers still backwards, Google applications still reverse.
Click to expand...
Click to collapse
what rom are you using?
EDIT: the only thing that need to change to you is the phone book is now need to be RTL and the number backwards
Gmail need the Graphic file
silverbluem said:
what rom are you using?
EDIT: the only thing that need to change to you is the phone book is now need to be RTL and the number backwards
Gmail need the Graphic file
Click to expand...
Click to collapse
My WM rom is OzDROID2.0, my Android rom is MDJ FroyoHD 3.7
Well, the phone book was never a problem for me, only hybrid text/numbers like in text messages etc.
Anyway, turns out I didn't modify framework.jar correctly, so I tried again using the script, and this time the phone just won't boot (like when I used Linux, it just hangs at boot screen).
Edit: Tried all day, all combinations of 'texts' files and with or w/o the 'graphics' file, and it always either just didn't fix anything (when I did the fix manually), or didn't boot at all (when I tried the script). This got me to conclude that I must not be doing it right, or else it would fail to boot for me as well (at least, I'm not even considering me being able to totally fix it myself )
Not a week ago, i was referred to the Samsung Galaxy S's newest ROM which came from Orange..
The rom includes (to my understanding) all the latest fixes regarding left to right text and even a hebrew version of Swype
It is easily retrievable. Obviously, it isn't legal to extract their work and use it to manutfacture a widespread ROM... but you can use it for personal use if you want to check how to fix that annoying hebrew thing.
+1000
Thanks
nir36 said:
Not a week ago, i was referred to the Samsung Galaxy S's newest ROM which came from Orange..
The rom includes (to my understanding) all the latest fixes regarding left to right text and even a hebrew version of Swype
It is easily retrievable. Obviously, it isn't legal to extract their work and use it to manutfacture a widespread ROM... but you can use it for personal use if you want to check how to fix that annoying hebrew thing.
Click to expand...
Click to collapse
It COULD be used to reverse engineer some of the stuff, but I doubt it's similar enough to the HD2 builds to use it.
+1
Thanks
Hebrew RTL Support
For those who are asking, i have made a working framework.jar , time ago.
It is working for most FROYO Sence, CM6.+ does not need it...
BUT NOT Desire HD Sence ( Because is is odex files, not only *.jar).
If needed i will upload it, and put a tutorial how to make it work...
Good Day!
RTL HEbrew
Please do that !
Thanks
Framework.jar
Tomorrow i will post the file with short tut how to put it, i must say that Ambious bring a good tut directly from iAndroid
Any way, Ambious, if i will upload the file please stick it to 1st page.
For now, good night...
This fix is a must for all RTL language users.
As mentioned, CM6+ already includes the fix and is working pretty good!
Problem is, for some reason, CM6 builds are rare...
I tried a few Sense builds but eventually i came back to a CM6 based build
because of it's support for RTL languages.
Devs, please include this fix in you builds, to make them as much accessible
as possible.
Thanks.
TheAgent1982 said:
Tomorrow i will post the file with short tut how to put it, i must say that Ambious bring a good tut directly from iAndroid
Any way, Ambious, if i will upload the file please stick it to 1st page.
For now, good night...
Click to expand...
Click to collapse
I sure will!
Thank you
However, as a Sense user myself, I'm pretty anxious to see if a fix can be applied to any of the Sense builds (especially DesireHD, which is my current build).
Well Organized Post
I have made well organized post for it:
RTL Support Post.
I must say, it will NOT Work for Desire HD for now, because it is ODEX and jar combined, and as you have read at iAndroid, for now there is NO solution for it,
and i do not have the experience and time to learn and convert it, since i am a student.
But i will give it a try between the semesters...
Hey,
The HD2 Desire HD builds are fully deodexed.
Froyo HD 3.7 for example: http://forum.xda-developers.com/showthread.php?t=795914
Maybe you could use them for preparing a RTL fix for when the deodexed desire HD ROMS come and for us HD2 android users.
Cheers.
It may be my semi-n00bness, but all my attempts to create a fix for DesireHD 3.7 failed.
Also, trying the supplied fix in the thread above on MDJ Sense Clean (non HD based) failed, wouldn't boot.
Hopefully someone can get it to work, and better yet - that the devs will incorporate those fixes in their builds.
Ever since the first froyo rom until now (currently running Nero 4.1), Fix Permissions in Rom Manager and ClockworkMod Recovery has been rendered useless. It simply starts for a second then ends right after, and permissions remain unfixed. Is this a problem due to lack of source from samsung or is this a bug that has not been detected by devs, either way if its solvable I think its a minor bug that should have some attention and maybe a fix.
Thank You!
I thought I had read something about having the proper busybox installed, but I have changed mine and can't seem to get it to work ether. I have also uninstalled and reinstalled RM.
No need for a think tank. There is already a solution.
Apparently the script in Clockwork is looking for a file in the wrong place. You can change the script or you can copy and move the file it's looking for. Either one will work. I am unsure if Koush has been contacted about this issue.
Check out this thread. I use the solution in post #3 and it works fine.
Also, if you feel as though someone is being rude, just ignore it and report the post. The mods act quickly as soon as something is brought to their attention.
-thanks for your suggestion...worked great.
Keslynn said:
No need for a think tank. There is already a solution.
Apparently the script in Clockwork is looking for a file in the wrong place. You can change the script or you can copy and move the file it's looking for. Either one will work. I am unsure if Koush has been contacted about this issue.
Check out this thread. I use the solution in post #3 and it works fine.
Also, if you feel as though someone is being rude, just ignore it and report the post. The mods act quickly as soon as something is brought to their attention.
Click to expand...
Click to collapse
--Thanks for keeping this thread on-point. Almost got side-tracked there with all the other posts. Follow Keslynn's attached link. The fix worked for me.
Moved of: Samsung Vibrant > Vibrant Android Development
To: Samsung Vibrant > Vibrant General
I'm trying to follow these directions... but I'm not sure where to get the packages.xml file.
Can someone please show me?
jnagar said:
Thank you--if it helps, I simply copied the packages.xml file into /data/system/ in order to run fix_permissions, and then just deleted the .xml file.
A temporary fix, yes, but I was just trying to fix a specific problem with ending phone calls causing an FC (see http://forum.xda-developers.com/showthread.php?p=9943863#post9943863).
Click to expand...
Click to collapse
rogue sound files
I wonder if permissions will fix the rogue sound files in my player?
Does anyone know if the fix permissions issue is limited to Rom Manager or if all other applications doing the same thing are affected? I tried using the "Root Tools" app to fix permissions, but it looks to be doing the same thing that occurs in rom manager.
- Mat
Hello everyone,
Since I bought my S5 I'm very happy with it, except for the Samsung Keyboard. Coming from a HTC where I had CyanogenMod 10.2 and the keyboard which came with it, I miss that particular keyboard a lot. I just need the keyboard to undo its suggestion-correction after I type backspace after I just typed a non-existing word which was corrected by the keyboard.
So what I did, I tried a few keyboards from the Play Store... which could not satisfy me... Then I searched the web and this forum, found the Google Android keyboard, which came very close in fulfilling my needs, but it misses the feature to long-press a character to get the symbols like ? and !. Which I really like...
So I just opened a CM zip and found the LatinIME apk. --> copied it to my phone, installed it just by opening it and for some minutes I was VERY HAPPY!!!! ...Until I found that the gesture typing feature did not gave me any words. The swype-line-thingy is visible when you swype the keyboard, but no words come out.
On the forum I read about this and most likely I miss the decoder now. See the thread "guide-how-to-enable-googles-gesture-t2012628".
But next to the fact that I don't get it completely, it looks like it requires root to replace the existing file in System/Lib. (by the way, is that a folder on my phone, or a folder in the rom you flash on the phone?)
I need to keep the warranty on my S5, so rooting was not part of my plan... yet...
But I just cannot believe I'm the only one having this issue. And yet, there's no thread explaining me how I should do this. So... Could anyone please help me getting the answer?
How to enable the gesture typing decoder on a not-rooted stock rom (4.4.2).
Thanks!!!
A pretty esoteric request. Nevertheless you identified a thread that spells out in detail how to copy the Google gesture decoder to your system. It's pretty straightforward so I don't know what you don't understand. You neglected to describe what part you didn't comprehend.
As the path is in the system directory, you will need root to make the changes. While you also neglected to tell us what S5 model you have, but provided that it isn't an Exynos model i.e. not a 900H, then you can root it without incrementing the Knox flag. Which means that you could revert root with no permanent evidence of having done so if necessary for a warranty claim.
So there seems to be no reason that you couldn't root your phone, install your gesture decoder and preserve your warranty. What appears to remain is that you need to do some reading to understand more about root, Knox and warranties.
.
Thanks for your response. It's appreciated!!
Okay, maybe I need to explain, I'm still a noob when it comes to rooting phones and Samsung specific knox counter shizzle. I know how to flash a rom on my old HTC, but that's quite it... But I'm willing to learn!!
I already did a search on the forum and found information about the knox counter and towel root and all I need to know to root my device. But to be honest, it scares the sh*t out of me to root my phone, having some kind of unknown (probably very little) risk of braking my expensive device...
My phone is the Samsung Galaxy S5 SM-G900F. Sorry for not mention that in the first place.
Regarding the thread I mentioned. I now do understand the part that whenever I root my phone and replace the .so file in the system/lib folder (on my phone ), it might/should work.
I thought the thread was talking about including the file in the ROM (zip file) you flash (using recovery) whenever you want to "install" that ROM on your phone. I already checked the ROM zip file and saw the so file in the system/lib folder. And since flashing a ROM is not what I'm going to do I thought it wasn't the way to go for me.
Okay, now what I was hoping for:
Is it possible to get (or build??) the LatinIME apk including the correct .so file, in order to install it without the need to root my phone?
Basically like I did with the apk I took from the CM 11 ROM zip file and the google keyboard apk. I just installed those. And the google keyboard has the right decoder in it since the gesture typing works with that one... and I do get the part that the decoder is a google thingy, so it might not be legal to create an apk myself and share it online...? But is building the apk again an option?
And since this keyboard is absolutely brilliant, I figured I wouldn't be the first noob who had this wish... and some other smart guys already build this apk with the right so file in it...
Okay. I hope I cleared up my question a little.
Thank you in advance for the answer!
If you don't want to root your phone that's fine. But then you don't get your gesture decoder. So pick one.
There is very little risk from rooting, but no one is going to tell you that it's foolproof or that there is zero risk. You could also have a meteorite land on your head or be hit by a bus when crossing the street. Does that keep you from crossing the street? Or do you accept a minimal risk and go ahead anyway? You have to decide how much risk you are going to accept and proceed from there.
I doubt anyone is going to build a Latin keyboard with a proprietary Google gesture decoder when it's so much simpler to copy the existing library or apk over to the system directory. But you can do an extended search to satisfy your curiosity if you wish. There is always a chance that someone did what you hope for.
Otherwise, you can use towel root and root your phone, et cetera. Or not, as you feel best. Not much else to say on the subject.
.
.... good point....
So... Time for me to become an "expert" on rooting then! :fingers-crossed:
It's just... when I cross a street, I know that the traffic is not coming from above or behind... just left and right... and before I cross I check those... Rooting my phone using tools feels to me like crossing the street blindfolded, trusting your ears... Most of the time it goes right...
Thanks for your help.
I'll place a post here when I'm done and happy typing with my keyboard. But that will take some time, since I'm pretty busy these days and I definitely need some more reading into this subject...
Thanks.
Re: new "developer's edition" N910V ROM compatability
From the few ROMs I've tried to flash so far, I've gotten a lot of error 7s in TWRP
As far as I can tell from some googling, this means that the updater-script in the ROM isn't allowing it to be installed on the device because it's not one of the ones in it's approved list based on some prop file somewhere
I think the fix to this is to edit the updater-script file by making it a .txt doc, deleting some amount of lines after the "assert," and changing it back to a file before putting it back into the ROM... so I'm trying to learn enough about coding to find out where exactly I should stop the deletion at. Or, alternatively, what I'd have to add.
It's also possible that I'm totally wrong and I'm getting this error for another reason entirely.
If anyone knows what they're doing here, I'd definitely be open to suggestions. If this is what the problem is, I imagine it won't be hard for devs to edit though.